[PATCH] D149154: [clang][Interp] Emit diagnostic when comparing function pointers

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 25 09:14:19 PDT 2023


aaron.ballman added inline comments.


================
Comment at: clang/lib/AST/Interp/Interp.h:652-653
+  const SourceInfo &Loc = S.Current->getSource(OpPC);
+  S.FFDiag(Loc, diag::note_constexpr_pointer_comparison_unspecified)
+      << LS << RS;
+  return false;
----------------
Can we pass in the result of `getType()` instead of doing this string conversion dance?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149154/new/

https://reviews.llvm.org/D149154



More information about the cfe-commits mailing list