[PATCH] D148992: [clang-repl] Fix dynamic library test to avoid cstdio and linker

Stefan Gränitz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 25 01:59:18 PDT 2023


sgraenitz added inline comments.


================
Comment at: clang/test/Interpreter/dynamic-library.cpp:12
+//   return 5;
+// }
 
----------------
Should we wrap this in a `extern "C"` block? Otherwise, the shared library has a C++ interface, which is not stable. It won't matter in this simple case, but the test might become a pattern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148992/new/

https://reviews.llvm.org/D148992



More information about the cfe-commits mailing list