[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

Kito Cheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 25 01:32:26 PDT 2023


kito-cheng added a comment.

> My concern would be that as we don't gate CSR names on enabling the relevant extension, people could start using CSR names and encodings that could change, without opting in via -menable-experimental-extensions, perhaps not realising that they're using the unratified version. OTOH, you could argue it was user error from the start by not trying to specify all the needed extensions in the ISA naming string.

We decide don't gate CSR before, but I am wondering maybe we should gate those CSR if they are defined by a unratified/experimental ext., and remove the checking once it ratified, since it might change the name or CSR number before ratified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148066/new/

https://reviews.llvm.org/D148066



More information about the cfe-commits mailing list