[PATCH] D148490: [AIX] use system assembler for assembly files

Qiu Chaofan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 24 19:14:21 PDT 2023


qiucf added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:427
+      Assembler.reset(buildAssembler());
+    return Assembler.get();
+  }
----------------
I saw we have a `ToolChain::getAssemble()` method. Can we use that directly?


================
Comment at: clang/test/Driver/aix-assembler.s:1
+
+// Check powerpc64-ibm-aix7.1.0.0, 64-bit.
----------------
Empty line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148490/new/

https://reviews.llvm.org/D148490



More information about the cfe-commits mailing list