[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Soumi Manna via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 24 12:09:43 PDT 2023


Manna added inline comments.


================
Comment at: clang/lib/Sema/SemaLookup.cpp:4662
 
-  for (auto KNPair : KnownNamespaces)
+  for (const auto &KNPair : KnownNamespaces)
     Namespaces.addNameSpecifier(KNPair.first);
----------------
tahonermann wrote:
> The element type is a pair of `NamespaceDecl *` and `bool`. I would skip this change.
Thanks @tahonermann for the explanation. Removed 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149074/new/

https://reviews.llvm.org/D149074



More information about the cfe-commits mailing list