[PATCH] D148110: [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if ctor call is written as list-initialization.

Mon Apr 24 06:52:08 PDT 2023

mboehme added a comment.

In D148110#4290400 <https://reviews.llvm.org/D148110#4290400>, @carlosgalvezp wrote:

> The commit message doesn't really tell me "what" this commit is fixing, it only points to a section of the Standard. It talks about "a false positive" but it doesn't tell what this FP is about. Could you write a little bit more about what the problem is? Preferably if you can link a Github issue describing the problem.

I've expanded the patch description to reference the specific test added here that used to be falsely diagnosed as a use-after-free.

I hope this is acceptable in lieu of a github issue?

> The subject of the commit message should indicate which particular check it relates to.

Done.

> Document change in release notes.

Done.

In D148110#4290905 <https://reviews.llvm.org/D148110#4290905>, @PiotrZSL wrote:

> Tests in lines 1195, 1201 actually tests InitListExpr.

That's understood. (These tests existed before this patch.)

> Test in line 1207 test negative scenario of CXXConstructExpr (list), but I didn't found any positive test for CXXConstructExpr with list expr, please add such test to show that warnings are still produced for such case.

Good point, done.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148110/new/

https://reviews.llvm.org/D148110