[PATCH] D149028: [Clang] Always pass `-fconvergent-functions` for GPU targets

Sun Apr 23 12:59:57 PDT 2023

jhuber6 added a comment.

In D149028#4290831 <https://reviews.llvm.org/D149028#4290831>, @JonChesterfield wrote:

> I think this is sensible. Passing fno-convergent-functions presumably changes the default?
>
> I wonder if we should adopt this and then remove the checks for each of the GPU programming models

That would probably make sense, actually that's a good point. MaskRay wanted me to remove `-fno-convergent-functions` in the previous patch which prevents us from doing that. I think I'll add it back in because I like the idea of being able to override defaults.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149028/new/

https://reviews.llvm.org/D149028