[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

Anubhab Ghosh via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 23 03:33:29 PDT 2023


argentite added inline comments.


================
Comment at: clang/lib/Interpreter/Offload.cpp:1
+//===-------------- Offload.cpp - CUDA Offloading ---------------*- C++ -*-===//
+//
----------------
v.g.vassilev wrote:
> argentite wrote:
> > Hahnfeld wrote:
> > > v.g.vassilev wrote:
> > > > How about `DeviceOffload.cpp`?
> > > Or `IncrementalCUDADeviceParser.cpp` for the moment - not sure what other classes will be added in the future, and if they should be in the same TU.
> > I wanted to avoid "CUDA" in case we use it later for HIP.
> Was `DeviceOffload.cpp` not a better name for the file and its intent?
Yeah that seems alright, I will change in the next revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146389/new/

https://reviews.llvm.org/D146389



More information about the cfe-commits mailing list