[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

Fri Apr 21 10:33:31 PDT 2023

aaron.ballman added a comment.

In D148276#4287931 <https://reviews.llvm.org/D148276#4287931>, @aaron.ballman wrote:

> In D148276#4287900 <https://reviews.llvm.org/D148276#4287900>, @thurston wrote:
>
>> I think this change is triggering an error on a buildbot (https://lab.llvm.org/buildbot/#/builders/37/builds/21631/steps/20/logs/stdio):
>>
>>   /b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Analysis/UnsafeBufferUsage.cpp:1348:45: error: cast from 'const clang::ASTContext' to 'clang::ASTContext &' drops const qualifier [-Werror,-Wcast-qual]
>>             std::remove_const_t<ASTContext &>(Ctx),
>>
>> even though the code is deliberately trying to remove the const qualifier the right (?) way.
>
> Ouch, that's pretty sad. I'll work around it and land a fix shortly, thank you for pointing this out!

Actually, that's going to be more involved than a quick fix. I think I'll revert the patch and reopen this review so that @sousajo can investigate the proper fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148276/new/

https://reviews.llvm.org/D148276