[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

Still suspicious about this/whether it models the MSVC implementation correctly, but no real implementation concerns.  I REALLY want us to document the attribute extensively however.



================
Comment at: clang/include/clang/Basic/AttrDocs.td:3543
+definition or a return statement. It has no effect on function declarations.
+This attribute permits constant evaluation of ``[[msvc::constexpr]]`` functions
+in ``[[msvc::constexpr]] return`` statements inside ``constexpr`` or
----------------
Does it prohibit the inverse?  I think this documentation overall needs a much better description of what the semantics are here, particularly anything that you found in experimentation on the MS implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134475/new/

https://reviews.llvm.org/D134475