[PATCH] D146987: [Assignment Tracking] Enable by default

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added a comment.

In D146987#4286797 <https://reviews.llvm.org/D146987#4286797>, @jmorse wrote:

> /me grumbles about all the world being a VAX,
>
> @mstorsjo I can't replicate the crash, but can replicate the valgrind jump-on-uninitialized-value with a small reproducer [0] that doesn't feature any debug-info

Ok, it's possible that bit was a red herring here. It didn't show up in a build of Clang instrumented with asan either.

> Could you confirm it's definitely assignment-tracking at fault by using `-Xclang -fexperimental-assignment-tracking=forced` to enable and `-Xclang -fexperimental-assignment-tracking=disabled` to disable, which should control the behaviour if it's AT at fault.

The `-Xclang -fexperimental-assignment-tracking=disabled` flag does make the assert that shows up when built with Xcode's clang go away at least. It doesn't affect the valgrind failure, so that's indeed unrelated.

So there's something in Clang/LLVM which behaves differently, to the point of triggering a failed assert, when built with Xcode's Clang (reproed with two different Xcode versions) but not on Linux (with GCC or Clang, at least with a possibly older Clang).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146987/new/

https://reviews.llvm.org/D146987