[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.
Herald added a subscriber: wlei.

>> Another point: having a diagnostic fire (failing a `-Werror` build) depending on the content of the profile passed to `-fprofile-use` seems pretty hostile to build workflows.
>
> Okay, this last point is especially compelling to me. I think opt remarks are probably the correct way to go.

Zombie comment, but I think optimization remarks and warnings for when the [[likely]] annotation doesn't match profile data already exist, see here: https://clang.llvm.org/docs/MisExpect.html (it predates this review by a few months, but I just learned about it recently).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134456/new/

https://reviews.llvm.org/D134456