[PATCH] D148835: [clang] removes trailing whitespace

Fri Apr 21 05:59:49 PDT 2023

erichkeane added a comment.

In D148835#4284871 <https://reviews.llvm.org/D148835#4284871>, @cjdb wrote:

> I've had some very good input about why this probably shouldn't go ahead: git history erasure :')

While that is a common criticism, if we're going to do this at all, we should do it in a single patch, as we can use --ignore-rev: https://akrabat.com/ignoring-revisions-with-git-blame/

This is a pretty common thing to do, and I don't think it should prevent us from doing this, which I think is the 'greater good' here.  The alternative is to continue having a bunch of unrelated patches piece-meal 'erase' git history as people accidentally fix these.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148835/new/

https://reviews.llvm.org/D148835