[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

[Nikolas Klauser via Phabricator via cfe-commits]

philnik added a comment.

I have to say I'm not really convinced this change is a good idea. The cases it flags don't really seem in any way ambiguous/erroneous.

In D147844#4286364 <https://reviews.llvm.org/D147844#4286364>, @chaitanyav wrote:

> @aaron.ballman please take a look.
>
> I filed a issue that premerge checks are not working on AIX
> https://github.com/google/llvm-premerge-checks/issues/441
>
> Not sure why the TSAN, MSAN and ASAN checks are failing on libcxx
> https://buildkite.com/llvm-project/libcxx-ci/builds/22664

The AIX builders are currently broken. That has to do with an update. We don't really know what's going on with the sanitizer builds, but these are unrelated too (probably also a problem with the builders).



================
Comment at: libcxx/include/strstream:303
         : ostream(&__sb_),
-          __sb_(__s, __n, __s + (__mode & ios::app ? _VSTD::strlen(__s) : 0))
         {}
----------------
Please don't change the indentation. It was correct before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147844/new/

https://reviews.llvm.org/D147844