[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

Jessica Clarke via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 20 15:11:50 PDT 2023


jrtc27 added inline comments.


================
Comment at: clang/test/Driver/riscv-default-build-attributes.s:3
+// RUN: %clang --target=riscv64 -### %s 2>&1 \
+// RUN:    | FileCheck %s -check-prefix CHECK-ENABLED
+
----------------
craig.topper wrote:
> jrtc27 wrote:
> > jrtc27 wrote:
> > > `=` for these
> > Also aren't these indented 1 too many spaces?
> Cleary I should not have copied ARM's test :(
Yeah... :( ARM and AArch64 tests can be pretty iffy in my experience


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148817/new/

https://reviews.llvm.org/D148817



More information about the cfe-commits mailing list