[PATCH] D148817: [RISCV] Add Tag_RISCV_arch attribute by default when using clang as an assembler.

[Jessica Clarke via Phabricator via cfe-commits]

jrtc27 added a comment.

Surprised that we didn't already do this; seems like a bit of an oversight.



================
Comment at: clang/test/Driver/riscv-default-build-attributes.s:1
+// Enabled by default for assembly
+// RUN: %clang --target=riscv64 -### %s 2>&1 \
----------------
Do we use /// for non-lit/FileCheck lines like we use ;; in IR tests?


================
Comment at: clang/test/Driver/riscv-default-build-attributes.s:11
+
+
+// Option ignored C/C++ (since we always emit hardware and ABI build attributes
----------------
Gap is a bit odd


================
Comment at: clang/test/Driver/riscv-default-build-attributes.s:12
+
+// Option ignored C/C++ (since we always emit hardware and ABI build attributes
+// during codegen).
----------------
missing "for"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148817/new/

https://reviews.llvm.org/D148817