[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Thank you.  Per my comment here:

> Also, AAPCS64 seems to define UnadjustedAlignment as the "natural alignment", and there's a doc comment saying it's the max of the type alignments. That makes me wonder if we should really be considering either the aligned attribute or #pragma pack in this computation at all; maybe we should just be looking at the type alignment.

Could you add tests for what happens when a struct is modified by the `aligned` attribute on a field and/or `#pragma pack` and make sure that we do... whatever the right thing here is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146242/new/

https://reviews.llvm.org/D146242