[PATCH] D148723: [clang] Enforce internal linkage for inline builtin
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 20 08:30:59 PDT 2023
erichkeane added inline comments.
================
Comment at: clang/lib/AST/ASTContext.cpp:11538
const FunctionDecl *FD) {
- if (!FD->isExternallyVisible())
+ if (!FD->isExternallyVisible() || FD->isInlineBuiltinDeclaration())
return GVA_Internal;
----------------
serge-sans-paille wrote:
> jyu2 wrote:
> > How about __declspec(dllimpor/dllexprort) __forceinline fexprl?
> Out of curiosity : where does the failing code comes from? A standard library or user-specific code? I assume standard library, in that case would you mind sharing a link to the source? I'm trying to understand the meaning we would like to give to an inline builtin with external linkage but force inline attribute.
I believe it comes from the version of math.h that we ship with MKL/our compiler in our downstream. We have our own separate implementation of much of math.h.
So you can pick it up from here: https://www.intel.com/content/www/us/en/developer/tools/oneapi/dpc-compiler.html (free download at least).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148723/new/
https://reviews.llvm.org/D148723
More information about the cfe-commits
mailing list