[PATCH] D147989: [clang] Fix Attribute Placement

Thu Apr 20 08:24:46 PDT 2023

ipriyanshi1708 marked 3 inline comments as done.
ipriyanshi1708 added a comment.

In D147989#4283666 <https://reviews.llvm.org/D147989#4283666>, @samtebbs wrote:

> This looks good to me now, nice work. Let's wait a few days for others' input to be safe.

okay! Thank You Sir.

================
Comment at: clang/lib/Sema/SemaDecl.cpp:5051
+        return 5;
+      else
+        return 4;
----------------
samtebbs wrote:
> Instead of returning 4 here, I think it's best to just delegate to the other `GetDiagnosticTypeSpecifierID` function. That way, if the IDs change for whatever reason they only have to updated in one place. This could be done cleanly by just making the call below be at the top level of the function (i.e. not inside an `else` block).
Ya that can be done. I will do it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147989/new/

https://reviews.llvm.org/D147989