[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

[serge via Phabricator via cfe-commits]

serge-sans-paille added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:11538
                                              const FunctionDecl *FD) {
-  if (!FD->isExternallyVisible())
+  if (!FD->isExternallyVisible() || FD->isInlineBuiltinDeclaration())
     return GVA_Internal;
----------------
jyu2 wrote:
> How about __declspec(dllimpor/dllexprort) __forceinline fexprl?
Out of curiosity : where does the failing code comes from? A standard library or user-specific code? I assume standard library, in that case would you mind sharing a link to the source? I'm trying to understand the meaning we would like to give to an inline builtin with external linkage but force inline attribute. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148723/new/

https://reviews.llvm.org/D148723