[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

Hi folks, the rationale for a clang-tidy check is enabling include-cleaner findings to be applied at scale and integrations into existing workflows (e.g. a lot of people run cleanups using clang-tidy findings hence there's somewhat existing infra for that).

current include-cleaner tool has some downsides when it comes to cleaning-up a whole codebase (e.g. it applies changes as it goes, which might result in breaking builds as it goes if not applied carefully), surely these shortcomings can be addressed by introducing more logic into the standalone tool, but it'd still lack the ecosystem & integrations clang-tidy has, which would be really unfortunate.
Could you give some details about how you're using the existing include-cleaner tool so that we better understand use cases around that one too?

As for the existing IWYU tool, include-cleaner library used in this check has a different interpretation of "use", so despite looking similar they have different implementations and might even disagree at certain cases due to these differences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148793/new/

https://reviews.llvm.org/D148793