[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

My one concern is that this is going to expose our incorrect instantiation of lambdas further and more painfully (see https://github.com/llvm/llvm-project/issues/58872).  Else, I don't see anything to be concerned about here.

I think the FIXME of adding a note diagnostic here should be fixed before committing however.



================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:965
+    case CodeSynthesisContext::LambdaExpressionSubstitution:
+      // FIXME: add a note for lambdas.
       break;
----------------
Would really like this note here, it shouldn't be too difficult, right? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148802/new/

https://reviews.llvm.org/D148802