[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 19 16:44:52 PDT 2023


MaskRay added a comment.

I hope that we add just one option, instead of aliases. Aliases are usually added for compatibility when something is deprecated or changed, not for new options.

My "Request Changes" status still holds. The patch hasn't fixed something obvious: the description mentions print-supported-marchs (well, it should really name the exact name, `--print-supported-marchs`, don't omit dashes) while the implementation uses `...extensions`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146054/new/

https://reviews.llvm.org/D146054



More information about the cfe-commits mailing list