[PATCH] D148556: [libcxxabi][demangle] create helper for std::string_view::starts_with

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 19 13:47:06 PDT 2023


MaskRay accepted this revision.
MaskRay added a comment.

> This was added to ADT in https://reviews.llvm.org/D148367 then reverted in https://reviews.llvm.org/D148547 because it was a layering violation pointed out in https://reviews.llvm.org/D148384#4270356.

This description requires readers to read the links. How about make the description self-contained with a brief message?

Add C++ 20 style starts_with to be used in LLVMDemangle. Due to library layering (LLVMSupport depends on LLVMDemangle), we add the utility header under llvm/Demangle, instead of llvm/ADT or llvm/Support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148556/new/

https://reviews.llvm.org/D148556



More information about the cfe-commits mailing list