[PATCH] D146987: [Assignment Tracking] Enable by default

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 19 13:21:53 PDT 2023


MaskRay added a comment.

In D146987#4281068 <https://reviews.llvm.org/D146987#4281068>, @Orlando wrote:

>> I think we may have an issue due to this. I'm basing that on the blamelist, but I'm still bisecting our build, which may take some time to confirm. Can you take a look, and revert if it's not a quick fix?
>
> That looks related to assignment tracking to me. I'm unlikely to get the chance to look into it until tomorrow morning (UK / BST), so I've reverted it for now. Thanks for the info.

Thanks, just one note: I think ideally a reland commit includes the original commit message, i.e. `See https://discourse.llvm.org/t/rfc-enable-assignment-tracking/69399 ...` :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146987/new/

https://reviews.llvm.org/D146987



More information about the cfe-commits mailing list