[clang] e67493f - [Driver] -fsanitize=kcfi doesn't need RequiresPIE

Fangrui Song via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 19 13:10:51 PDT 2023


Author: Fangrui Song
Date: 2023-04-19T13:10:46-07:00
New Revision: e67493f57262862ae2bd4fc5d1d1f552676d815f

URL: https://github.com/llvm/llvm-project/commit/e67493f57262862ae2bd4fc5d1d1f552676d815f
DIFF: https://github.com/llvm/llvm-project/commit/e67493f57262862ae2bd4fc5d1d1f552676d815f.diff

LOG: [Driver] -fsanitize=kcfi doesn't need RequiresPIE

As mentioned on D148671: this is unneeded. This commit is a no-op for most Linux
builds since CLANG_DEFAULT_PIE_ON_LINUX defaults to 1.

Added: 
    

Modified: 
    clang/lib/Driver/SanitizerArgs.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/SanitizerArgs.cpp b/clang/lib/Driver/SanitizerArgs.cpp
index 3c24089e0157a..d0dd294e3fe2f 100644
--- a/clang/lib/Driver/SanitizerArgs.cpp
+++ b/clang/lib/Driver/SanitizerArgs.cpp
@@ -39,7 +39,7 @@ static const SanitizerMask NotAllowedWithTrap = SanitizerKind::Vptr;
 static const SanitizerMask NotAllowedWithMinimalRuntime =
     SanitizerKind::Function | SanitizerKind::Vptr;
 static const SanitizerMask RequiresPIE =
-    SanitizerKind::DataFlow | SanitizerKind::Scudo | SanitizerKind::KCFI;
+    SanitizerKind::DataFlow | SanitizerKind::Scudo;
 static const SanitizerMask NeedsUnwindTables =
     SanitizerKind::Address | SanitizerKind::HWAddress | SanitizerKind::Thread |
     SanitizerKind::Memory | SanitizerKind::DataFlow;


        


More information about the cfe-commits mailing list