[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

[Jennifer Yu via Phabricator via cfe-commits]

jyu2 added a comment.

Hi @serge-sans-paille, thanks for the fix.  Could you please also try some test with dllimport/dllexport with inline function?  Jennifer



================
Comment at: clang/lib/AST/ASTContext.cpp:11538
                                              const FunctionDecl *FD) {
-  if (!FD->isExternallyVisible())
+  if (!FD->isExternallyVisible() || FD->isInlineBuiltinDeclaration())
     return GVA_Internal;
----------------
How about __declspec(dllimpor/dllexprort) __forceinline fexprl?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148723/new/

https://reviews.llvm.org/D148723