[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/include/clang/Basic/riscv_sifive_vector.td:46
+
+multiclass RVVVCIXBuiltinSet<list<string> range, string prototype,
+                             list<int> intrinsic_types, bit EncodeVtype,
----------------
We might consider breaking this class into 2 different classes. One for EncodeVtype=1 and EncodeVtype=0. The simplification might be worth the little bit of duplication.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148223/new/

https://reviews.llvm.org/D148223