[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 18 21:59:13 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:903
+    return createStringError(errc::invalid_argument,
+                             "zcmt is not allowed when c is specified");
+
----------------
Extension names should be in single quotes.

Should we use `'zcmt' and 'c' extensions are incompatible` to match line 863?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133863/new/

https://reviews.llvm.org/D133863



More information about the cfe-commits mailing list