[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

Noah Goldstein via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 18 13:54:04 PDT 2023


goldstein.w.n added a comment.

LGTM.

I'm not a maintainer to please wait a day or so to push so that others can review.



================
Comment at: clang/lib/Headers/pmmintrin.h:278
 ///    the monitor event pending state. Data stored in the monitored address
 ///    range causes the processor to exit the pending state.
 ///
----------------
interrupts too. Might as well add that if updating the comments.


================
Comment at: clang/lib/Headers/pmmintrin.h:291
 /// \param __hints
-///    Optional hints for the monitoring state, which may vary by processor.
+///    Optional hints for the monitoring state, which can vary by processor.
 static __inline__ void __DEFAULT_FN_ATTRS
----------------
out of curiosity, why "may" -> "can"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148653/new/

https://reviews.llvm.org/D148653



More information about the cfe-commits mailing list