[PATCH] D148554: [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:15-16
+
+// The Arena owns the objects that model data within an analysis.
+// Currently this is mostly Values and StorageLocations.
+class Arena {
----------------
mboehme wrote:
> gribozavr2 wrote:
> > 
> While we're at it, put `Arena` in backticks as well?
Added triple-slashes and changed to "example" so it's less prone to getting out of date (which I think was the point?).

I kept this split as two sentences to preserve a self-contained one-line description for readability.

Quoting the name of the class itself breaks the flow of the sentence to emphasize that this is a reference, but that doesn't seem necessary in the class declaration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148554/new/

https://reviews.llvm.org/D148554