[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

Alexander Shaposhnikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 17 09:53:27 PDT 2023


alexander-shaposhnikov added inline comments.


================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:227
+        (TSTy = Ty->getAs<TemplateSpecializationType>()))
+      Result.addOuterTemplateArguments(const_cast<FunctionTemplateDecl *>(FTD),
+                                       TSTy->template_arguments(),
----------------
erichkeane wrote:
> So I'd come up with something similar, but this ends up being a little goofy?  And I thought it didn't really work in 1 of the cases.  I wonder if we're better off looking at the decl contexts to try to figure out WHICH of the cases we are, and just set the next decl context based on that?
sure, we can try. In the meantime - regarding GH62110 - do you happen to have any thoughts on that ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146178/new/

https://reviews.llvm.org/D146178



More information about the cfe-commits mailing list