[PATCH] D148433: [clang] Add tests for DRs about complete-class context

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 17 08:53:45 PDT 2023


shafik added subscribers: aaron.ballman, rsmith.
shafik added inline comments.


================
Comment at: clang/test/CXX/drs/dr18xx.cpp:139
 
+namespace dr1890 { // dr1890: no drafting
+// FIXME: all the examples are well-formed.
----------------
So this is still in drafting: https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#1890

We saw this in Issaquah and we felt like 1890 would probably be resolved once we resolve 2335: https://www.open-std.org/JTC1/SC22/WG21/docs/cwg_active.html#2335

I think we are leaning towards these being well-formed but we won't really know till it is resolved. 


================
Comment at: clang/test/CXX/drs/dr23xx.cpp:42
 
+namespace dr2335 { // dr2335: no drafting
+// FIXME: all of the examples are well-formed.
----------------
My comment on 1890 applies here as well.

CC @rsmith @aaron.ballman how should we handle DRs that are still in process? While we may think we know the direction it is going in, it could change.

So maybe we should avoid expressing an opinion on whether these are well-formed or not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148433/new/

https://reviews.llvm.org/D148433



More information about the cfe-commits mailing list