[PATCH] D148419: [clang][AST] Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as evaluation failure

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D148419#4273901 <https://reviews.llvm.org/D148419#4273901>, @hazohelet wrote:

> @aaron.ballman 
> Sorry, this change is breaking the buildbot and because I don't have commit access I would like you to revert it for me.
> It seems we need to specify the std option in the test code.
>
>   BUILD FAILED: 41435 expected passes 84 expected failures 28291 unsupported tests 1 unexpected failures (failure)
>   
>   Step 5 (build-unified-tree) warnings: Build unified tree
>   /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/lib/CodeGen/MachineModuleInfo.cpp:73:51: warning: ‘this’ pointer is null [-Wnonnull]
>   
>   Step 6 (test-build-unified-tree-check-all) failure: 41435 expected passes 84 expected failures 28291 unsupported tests 1 unexpected failures (failure)
>   ******************** TEST 'Clang :: SemaCXX/crash-lambda-weak-attr.cpp' FAILED ********************
>   Script:
>   --
>   : 'RUN: at line 1';   /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang -cc1 -internal-isystem /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/lib/clang/17/include -nostdsysteminc -fsyntax-only -verify /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/SemaCXX/crash-lambda-weak-attr.cpp
>   --
>   Exit Code: 1
>   
>   Command Output (stderr):
>   --
>   error: 'error' diagnostics seen but not expected: 
>     File /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/SemaCXX/crash-lambda-weak-attr.cpp Line 6: a lambda expression may not appear inside of a constant expression
>   error: 'warning' diagnostics seen but not expected: 
>     File /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/SemaCXX/crash-lambda-weak-attr.cpp Line 6: 'static_assert' with no message is a C++17 extension
>   error: 'note' diagnostics expected but not seen: 
>     File /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/SemaCXX/crash-lambda-weak-attr.cpp Line 6: comparison against pointer to weak member 'Weak::weak_method' can only be performed at runtime
>     File /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/SemaCXX/crash-lambda-weak-attr.cpp Line 6: in call to
>   error: 'note' diagnostics seen but not expected: 
>     File /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/SemaCXX/crash-lambda-weak-attr.cpp Line 6: non-literal type '(lambda at /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/SemaCXX/crash-lambda-weak-attr.cpp:6:15)' cannot be used in a constant expression
>   5 errors generated.
>   
>   --
>   
>   ********************

I noticed that as well and corrected the issue in a4edc2c9fa35a763fc5f4c9cf6383096a13a9cf6 <https://reviews.llvm.org/rGa4edc2c9fa35a763fc5f4c9cf6383096a13a9cf6>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148419/new/

https://reviews.llvm.org/D148419