[PATCH] D148419: [clang][AST] Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as evaluation failure

Mon Apr 17 05:58:51 PDT 2023

hazohelet marked an inline comment as done.
hazohelet added a comment.

In D148419#4273551 <https://reviews.llvm.org/D148419#4273551>, @aaron.ballman wrote:

> LGTM, though the changes need a release note. Do you still need someone to commit on your behalf? (Alternatively, you could consider requesting commit access: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)

Since I don't have commit access, I would like you to commit this on my behalf. Please use "Takuya Shimizu <shimizu2486 at gmail.com>" as patch attribution.
I'll try requesting commit access. Thanks!

================
Comment at: clang/test/SemaCXX/crash-lambda-weak-attr.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++2b %s
+
----------------
aaron.ballman wrote:
> I don't think we need this to be in C++2b mode explicitly, right?
Yeah, we don't need it

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148419/new/

https://reviews.llvm.org/D148419