[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

Jun Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 17 04:33:18 PDT 2023


junaire accepted this revision.
junaire added a comment.
This revision is now accepted and ready to land.

This patch fixes issues that have not been found in the past. This unblocks D141215 <https://reviews.llvm.org/D141215> and D146809 <https://reviews.llvm.org/D146809>. Since it's only relevant to the clang-repl, I believe this is safe to just land it. (I added these assertions in  https://reviews.llvm.org/rGcd64a427efa0baaf1bb7ae624d4301908afc07f7 ) However, it will be nice if other reviewers, maybe @rjmccall could take a look at this as well.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148435/new/

https://reviews.llvm.org/D148435



More information about the cfe-commits mailing list