[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

Qingyuan Zheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 16 21:04:50 PDT 2023


daiyousei-qz added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:1281
 }
+std::optional<HighlightingKind>
+highlightingKindFromString(llvm::StringRef Name) {
----------------
I'm not sure if we should parse the enums here or in parsing configs using `EnumSwitch`. The problem is that I don't want to introduce dependencies to "SemanticHighlighting.h" in "ConfigCompile.cpp".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148489/new/

https://reviews.llvm.org/D148489



More information about the cfe-commits mailing list