[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

[Stefan Gränitz via Phabricator via cfe-commits]

sgraenitz accepted this revision.
sgraenitz added a comment.
This revision is now accepted and ready to land.

Thanks. Maybe you can fix this one detail and add a description like "Most of Orc and JITLink are movinng away from JITTargetAddress and use ExecutorAddr instead"? Otherwise LGTM.



================
Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:88
     return Sym.takeError();
-  return Sym->getValue();
+  return llvm::orc::ExecutorAddr(Sym->getValue());
 }
----------------
I think `Sym` is a `Expected<ExecutorAddr>` already


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148434/new/

https://reviews.llvm.org/D148434