[PATCH] D141215: [clang-repl] Introduce Value to capture expression results
Jun Zhang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Apr 15 10:01:20 PDT 2023
junaire marked an inline comment as done.
junaire added inline comments.
================
Comment at: clang/include/clang/Interpreter/Value.h:83
+ Value() = default;
+ Value(void /*Interpreter*/ *In, void /*QualType*/ *Ty);
+ Value(const Value &RHS);
----------------
aaron.ballman wrote:
> Why do these take `void *` instead of the expected type?
Yeah for the first parameter, we could just use `Interpreter*` but the second one is an opaque type so I think we should keep it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141215/new/
https://reviews.llvm.org/D141215
More information about the cfe-commits
mailing list