[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

Jun Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 15 09:42:28 PDT 2023


junaire marked 4 inline comments as done.
junaire added inline comments.


================
Comment at: clang/include/clang/Interpreter/Interpreter.h:83
   /// mangled name.
   llvm::Expected<llvm::JITTargetAddress> getSymbolAddress(GlobalDecl GD) const;
 
----------------
sgraenitz wrote:
> Most of the Orc and JITLink moved away from `JITTargetAddress` already and uses `ExecutorAddr` nowadays. I think we should use `ExecutorAddr` from the beginning in this patch.
Thanks, I've created https://reviews.llvm.org/D148434


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141215/new/

https://reviews.llvm.org/D141215



More information about the cfe-commits mailing list