[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 15 07:57:34 PDT 2023


njames93 added a comment.

In D146842#4271144 <https://reviews.llvm.org/D146842#4271144>, @PiotrZSL wrote:

> In D146842#4271089 <https://reviews.llvm.org/D146842#4271089>, @njames93 wrote:
>
>> I think this should be split up into 2 separate patches, one for each of the proposed changes and each can be reviewed on their own.
>
> I don't plan to split this.

The LLVM Guidelines <https://llvm.org/docs/Contributing.html#how-to-submit-a-patch> state that patches should only contain one isolated change, independent changes should be sent as multiple patches. 
Given the only overlap between these 2 changes is the fact they are using the same test file. These qualify as being isolated changes and should be handled as such.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146842/new/

https://reviews.llvm.org/D146842



More information about the cfe-commits mailing list