[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 15 02:38:14 PDT 2023


PiotrZSL added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-override-templates.cpp:46
+  // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override]
+  // CHECK-FIXES: {{^}}  void boo3() override;{{$}}
+};
----------------
carlosgalvezp wrote:
> Same as above, start/end markers seem to not be needed.
I will remove it, but note that If I do that, test will still pass if I comment out removal of virtual keyword in code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147924/new/

https://reviews.llvm.org/D147924



More information about the cfe-commits mailing list