[PATCH] D147081: [clang-tidy] Fix issues in bugprone-assert-side-effect

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp added a comment.

You mention in the commit message that it fixes #25569, but that seems unrelated (and is already closed)?

Personally I find it hard to review 2 github issue fixes + 1 NFC (moving the assert code to assert.h) on the same patch, would it be possible to split to have a more focused review? I believe that would improve both speed and quality of the review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147081/new/

https://reviews.llvm.org/D147081