[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 14 14:39:10 PDT 2023


shafik added inline comments.


================
Comment at: clang/lib/Sema/SemaInit.cpp:5332
+        if (Arg)
+          IS.Diagnose(S, SubEntity, SubKind, Arg);
+        else
----------------
Do we have tests that trigger this diagnostic and the one right below?


================
Comment at: clang/lib/Sema/SemaInit.cpp:9264
       cast<FieldDecl>(Entity.getDecl())->isBitField())
     S.CheckBitFieldInitialization(Kind.getLocation(),
                                   cast<FieldDecl>(Entity.getDecl()),
----------------
I don't see any tests that checks this set of diagnostics for parens init. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148274/new/

https://reviews.llvm.org/D148274



More information about the cfe-commits mailing list