[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

[Argyrios Kyrtzidis via Phabricator via cfe-commits]

akyrtzi added inline comments.


================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905
+  if (BriefResult) {
+    llvm::outs() << "num modules: " << FD->getNumModules() << '\n';
+    return HadErrors;
----------------
jansvoboda11 wrote:
> This assumes `FD` is not empty, i.e. the `-format experimental-full` argument. We should probably error out early if that's not the case.
> 
> WDYT about changing the new `-brief` flag into something like `-format experimental-brief`? We could avoid the dependency between arguments and we'd also make it clear the `make` and `p1689` don't have a brief variant.
> This assumes FD is not empty,

Ah, good catch! I'll fix.

> WDYT about changing the new -brief flag into something like -format experimental-brief? 

I consider `-brief` orthogonal to the format kind, there's no reason we can't have brief versions of the other formats.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148369/new/

https://reviews.llvm.org/D148369