[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added a comment.

Thank you for the fix!

While this will fix the crash I am a little concerned that I don't a diagnostic for each place we call `ActOnParamDefaultArgumentError(...)`, there is only once place where we diagnose this the rest don't. So I wonder if this was purposeful or not.

We are not actually diagnosing the main problem which is a malformed conditional expression. I would hope that we would error out on that. That feels like where we should be applying the fix to me.

If you have malformed conditional expressions in other situation we do diagnose that. I was trying to debug why we don't catch this case but the code around parsing conditional expressions is involved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148372/new/

https://reviews.llvm.org/D148372