[PATCH] D148344: [clang][dataflow] Refine matching of optional types to anchor at top level.
Gábor Horváth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 14 10:09:39 PDT 2023
xazax.hun added inline comments.
================
Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:262
/// Returns true if and only if `Type` is an optional type.
bool isOptionalType(QualType Type) {
if (!Type->isRecordType())
----------------
Why do we need two places to define what is an optional type? Would it be possible to somehow reuse the Declaration matcher on the RecordDecel here? Or would that be bad for performance?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148344/new/
https://reviews.llvm.org/D148344
More information about the cfe-commits
mailing list