[PATCH] D78644: [LSan] Enable for SystemZ

Fri Apr 14 09:29:54 PDT 2023

MaskRay added a comment.

In D78644#4268685 <https://reviews.llvm.org/D78644#4268685>, @iii wrote:

> I guess the intention is dropping the special case? The following patch passes regtests:
>
>   --- a/compiler-rt/lib/lsan/lsan_allocator.h
>   +++ b/compiler-rt/lib/lsan/lsan_allocator.h
>   @@ -68,9 +68,6 @@ using PrimaryAllocator = PrimaryAllocatorASVT<LocalAddressSpaceView>;
>    # if SANITIZER_FUCHSIA || defined(__powerpc64__)
>    const uptr kAllocatorSpace = ~(uptr)0;
>    const uptr kAllocatorSize  =  0x40000000000ULL;  // 4T.
>   -#elif defined(__s390x__)
>   -const uptr kAllocatorSpace = 0x40000000000ULL;
>   -const uptr kAllocatorSize = 0x40000000000ULL;  // 4T.
>    # else
>    const uptr kAllocatorSpace = 0x600000000000ULL;
>    const uptr kAllocatorSize  = 0x40000000000ULL;  // 4T.
>
> `0x50000000000ULL` worked as well.

Thank you! I will try removing the special case in D148193 <https://reviews.llvm.org/D148193>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78644/new/

https://reviews.llvm.org/D78644