[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 14 05:42:36 PDT 2023


hans added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583
+  llvm::sys::path::Style Style =
+      llvm::sys::path::is_absolute(ObjFileNameForDebug)
+          ? llvm::sys::path::Style::native
----------------
Won't the code above (line 580) make many filenames absolute and cause us to use native slashes even when we want backslashes?

This would also need a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147256/new/

https://reviews.llvm.org/D147256



More information about the cfe-commits mailing list