[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 14 00:38:09 PDT 2023


MyDeveloperDay added a comment.

In D137327#4267239 <https://reviews.llvm.org/D137327#4267239>, @thieta wrote:

> In D137327#4235255 <https://reviews.llvm.org/D137327#4235255>, @MyDeveloperDay wrote:
>
>> In D137327#4234463 <https://reviews.llvm.org/D137327#4234463>, @thieta wrote:
>>
>>> This was released in LLVM 16.0.0.
>>
>> The prior behaviour was there before, it’s marked in GitHub as a regression, can you please revert, we’ll mark the issue to be cherry picked, then let’s go back and rework a solution that means your issue can be resolved
>
> Sorry this slipped under my radar. Can you please push a revert to `main` and then file a issue to backport this to the release branch if it's something you still want to do. It's hard for me to keep track of the issues unless they are added to the 16.x milestone.

You have commit rights correct? you really need to own your change especially if it causes a regression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137327/new/

https://reviews.llvm.org/D137327



More information about the cfe-commits mailing list